Skip to content

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Dec 21, 2024

What does the PR do?

  • asyncio.get_event_loop() was deprecated in Python 3.12.
  • Initialize gRPC client inside the async loop.

More details in the Jira ticket.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • ci

Related PRs:

Where should the reviewer start?

Test plan:

L0_model_control_stress_valgrind_massif_vllm--base
L0_model_control_stress_valgrind_vllm--base
L0_model_control_stress_vllm--base

  • CI Pipeline ID:
    21774566

Caveats:

Background

Pipeline job failures

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the bug Something isn't working label Dec 21, 2024
@yinggeh yinggeh self-assigned this Dec 21, 2024
@yinggeh yinggeh changed the title Fix L0_model_control_stress_vllm ci: Fix L0_model_control_stress_vllm Dec 21, 2024
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@yinggeh yinggeh merged commit d061556 into main Dec 23, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7765-fix-L0-model-control-stress-vllm branch December 30, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants